-
Notifications
You must be signed in to change notification settings - Fork 22
[apps/api] feat: allow oauth for regional bots #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Loving it 😍 Thanks a lot @lilyydu for your work on this. I have several comments after going through the changes. Have you considered using OAuthUrl as the setting's name instead of tokenUrl? I understand the choice for tokenUrl as it is the URL to get the token but the bot service doc talks about OAuth URL in OAuth URL support in Azure AI Bot Service for example so it might be good to be aligned. Regarding the instructions for setting up:
Regarding the CLI templates:
|
… instructions to test sample README
resolves: #367
ClientSettingsthats passed into our clients from the app layertokenUrlspecifies the regional token endpoint to use (e.g., europe.token.botframework)I didn't reuse
OauthSettingsbecausea) its associated w/ the Apps ecosystem vs
ClientSettingsis concerned w the API layerb) eventually may diverge with additional params
b) would cause circular dependencies
INSTRUCTIONS FOR SETTING UP
(documenting here for now, should add to docs, partial courtesy to @Benjiiim):
resources: